Skip to content

Commit c4eacbf

Browse files
mattipmalfet
mattip
authored and
malfet
committed
fix formatting CIRCLE_TAG when building docs (#67026)
Summary: Similar to pytorch/text#1416 malfet, brianjo The previous code failed when tags changed from `v0.9.0` to `v0.10.0`. I tested this offline, it would be nice to somehow be actually tag the repo and see that this adds the correct documentation directory to the pytorch/pytorch.github.io repo. Pull Request resolved: #67026 Reviewed By: saketh-are Differential Revision: D31843381 Pulled By: malfet fbshipit-source-id: 21526ad9ed4c1751c2d7f6d621da305f166a7f55
1 parent 932ac7b commit c4eacbf

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

‎.circleci/config.yml‎

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.circleci/verbatim-sources/job-specs/job-specs-custom.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@
4343
set -ex
4444
export COMMIT_DOCKER_IMAGE=${DOCKER_IMAGE}:build-${DOCKER_TAG}-${CIRCLE_SHA1}
4545
echo "DOCKER_IMAGE: "${COMMIT_DOCKER_IMAGE}
46-
tag=${CIRCLE_TAG:1:5}
46+
# turn v1.12.0rc3 into 1.12.0
47+
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
4748
target=${tag:-master}
4849
echo "building for ${target}"
4950
time docker pull ${COMMIT_DOCKER_IMAGE} >/dev/null
@@ -88,6 +89,8 @@
8889
set -ex
8990
export COMMIT_DOCKER_IMAGE=${DOCKER_IMAGE}:build-${DOCKER_TAG}-${CIRCLE_SHA1}
9091
echo "DOCKER_IMAGE: "${COMMIT_DOCKER_IMAGE}
92+
# turn v1.12.0rc3 into 1.12.0
93+
tag=$(echo $CIRCLE_TAG | sed -e 's/v*\([0-9.]*\).*/\1/')
9194
tag=${CIRCLE_TAG:1:5}
9295
target=${tag:-master}
9396
echo "building for ${target}"

0 commit comments

Comments
 (0)