matches_jit_signatures is dead (#53637)

ezyang · facebook-github-bot · commit 6c327ef9d465 · 2021-04-15T12:31:19.000-07:00
Summary: Pull Request resolved: #53637 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D26920687 Pulled By: ezyang fbshipit-source-id: 288bd9dca63da04ccc633d939833066a3305a68a
diff --git a/aten/src/ATen/native/README.md b/aten/src/ATen/native/README.md
@@ -365,20 +365,6 @@ you're a function that simply does not interact with any devices. In
 that case, code generation of the device guard can be disabled by adding
 `device_guard: False` to your function definition.
 
-### `matches_jit_signature`
-
-```
-matches_jit_signature: False
-```
-
-This will indicate that the func syntax does not follow the JIT signature schema.
-If you are a triggering an assert related to JIT signature compliance
-try adding this field and setting it to False. In general, this serves as a means
-of tracking an ongoing schema unification with the goal of aligning func syntax
-with other components of PyTorch in order to reduce overall complexity.
-If you find yourself having to set this field to False add @gchanan to your PR's
-set of reviewers.
-
 ### `manual_kernel_registration`
 
 ```
diff --git a/tools/codegen/gen.py b/tools/codegen/gen.py
@@ -628,7 +628,6 @@ def compute_declaration_yaml(f: NativeFunction) -> object:
         ('overload_name', str(f.func.name.overload_name)),
         ('manual_kernel_registration', f.manual_kernel_registration),
         ('category_override', f.category_override if f.category_override is not None else ''),
-        ('matches_jit_signature', True),
         ('schema_string', f'aten::{f.func}'),
         ('arguments', arguments),
         ('schema_order_cpp_signature', schema_order_cpp_signature),
diff --git a/tools/shared/cwrap_common.py b/tools/shared/cwrap_common.py
@@ -25,8 +25,6 @@ def set_declaration_defaults(declaration):
         # This happens for legacy TH bindings like
         # _thnn_conv_depthwise2d_backward
         declaration['schema_string'] = ''
-    if 'matches_jit_signature' not in declaration:
-        declaration['matches_jit_signature'] = False
     declaration.setdefault('arguments', [])
     declaration.setdefault('return', 'void')
     if 'cname' not in declaration:
