Skip to content

Commit 651c24f

Browse files
Update on "Make test_export training IR compatible"
In this PR, I make test_export to be compatible with training IR. The idea is that when we flip the IR to non-functional training IR, all these tests should be green. The changes involve reading through the test case, and add necessary decomposition etc to make sure the tests pass. For example, if the tests expect to see mutated buffers returned, we need to get them via running run_decomp. Differential Revision: [D64732360](https://our.internmc.facebook.com/intern/diff/D64732360) [ghstack-poisoned]
2 parents bff2ea2 + 05334ce commit 651c24f

File tree

601 files changed

+7191
-8035
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

601 files changed

+7191
-8035
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ca4783992ed7602a39528ba304d61f00396b2a5a
1+
export-D64151426

.ci/docker/libtorch/Dockerfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ RUN bash ./install_cuda.sh 12.4
6666
RUN bash ./install_magma.sh 12.4
6767
RUN ln -sf /usr/local/cuda-12.4 /usr/local/cuda
6868

69+
FROM cuda as cuda12.6
70+
RUN bash ./install_cuda.sh 12.6
71+
RUN bash ./install_magma.sh 12.6
72+
RUN ln -sf /usr/local/cuda-12.6 /usr/local/cuda
73+
6974
FROM cpu as rocm
7075
ARG PYTORCH_ROCM_ARCH
7176
ENV PYTORCH_ROCM_ARCH ${PYTORCH_ROCM_ARCH}

.ci/docker/requirements-ci.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ tb-nightly==2.13.0a20230426
257257
#test that import:
258258

259259
# needed by torchgen utils
260-
typing-extensions
260+
typing-extensions>=4.10.0
261261
#Description: type hints for python
262262
#Pinned versions:
263263
#test that import:
@@ -331,7 +331,7 @@ sympy==1.13.1 ; python_version >= "3.9"
331331
#Pinned versions:
332332
#test that import:
333333

334-
onnx==1.16.1
334+
onnx==1.17.0
335335
#Description: Required by mypy and test_public_bindings.py when checking torch.onnx._internal
336336
#Pinned versions:
337337
#test that import:

.ci/pytorch/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ if [[ "$BUILD_ENVIRONMENT" == *clang9* ]]; then
8181
#
8282
# int main(int argv) {
8383
# Tensor b = empty({3, 4});
84-
# auto z = call(b, b.sym_sizes(), b.sym_strides(), c10::nullopt);
84+
# auto z = call(b, b.sym_sizes(), b.sym_strides(), std::nullopt);
8585
# }
8686
export VALGRIND=OFF
8787
fi

.github/scripts/generate_ci_workflows.py

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -114,20 +114,21 @@ class OperatingSystem:
114114
isolated_workflow=True,
115115
),
116116
),
117-
BinaryBuildWorkflow(
118-
os=OperatingSystem.LINUX,
119-
package_type="manywheel",
120-
build_configs=generate_binary_build_matrix.generate_wheels_matrix(
121-
OperatingSystem.LINUX,
122-
use_split_build=True,
123-
arches=["11.8", "12.1", "12.4", "cpu"],
124-
),
125-
ciflow_config=CIFlowConfig(
126-
labels={LABEL_CIFLOW_BINARIES, LABEL_CIFLOW_BINARIES_WHEEL},
127-
isolated_workflow=True,
128-
),
129-
use_split_build=True,
130-
),
117+
# See https://github.com/pytorch/pytorch/issues/138750
118+
# BinaryBuildWorkflow(
119+
# os=OperatingSystem.LINUX,
120+
# package_type="manywheel",
121+
# build_configs=generate_binary_build_matrix.generate_wheels_matrix(
122+
# OperatingSystem.LINUX,
123+
# use_split_build=True,
124+
# arches=["11.8", "12.1", "12.4", "cpu"],
125+
# ),
126+
# ciflow_config=CIFlowConfig(
127+
# labels={LABEL_CIFLOW_BINARIES, LABEL_CIFLOW_BINARIES_WHEEL},
128+
# isolated_workflow=True,
129+
# ),
130+
# use_split_build=True,
131+
# ),
131132
BinaryBuildWorkflow(
132133
os=OperatingSystem.LINUX,
133134
package_type="conda",
@@ -180,21 +181,22 @@ class OperatingSystem:
180181
),
181182
branches="main",
182183
),
183-
BinaryBuildWorkflow(
184-
os=OperatingSystem.LINUX,
185-
package_type="manywheel",
186-
build_configs=generate_binary_build_matrix.generate_wheels_matrix(
187-
OperatingSystem.LINUX,
188-
arches=["11.8", "12.1", "12.4"],
189-
python_versions=["3.9"],
190-
use_split_build=True,
191-
),
192-
ciflow_config=CIFlowConfig(
193-
labels={LABEL_CIFLOW_PERIODIC},
194-
),
195-
branches="main",
196-
use_split_build=True,
197-
),
184+
# See https://github.com/pytorch/pytorch/issues/138750
185+
# BinaryBuildWorkflow(
186+
# os=OperatingSystem.LINUX,
187+
# package_type="manywheel",
188+
# build_configs=generate_binary_build_matrix.generate_wheels_matrix(
189+
# OperatingSystem.LINUX,
190+
# arches=["11.8", "12.1", "12.4"],
191+
# python_versions=["3.9"],
192+
# use_split_build=True,
193+
# ),
194+
# ciflow_config=CIFlowConfig(
195+
# labels={LABEL_CIFLOW_PERIODIC},
196+
# ),
197+
# branches="main",
198+
# use_split_build=True,
199+
# ),
198200
BinaryBuildWorkflow(
199201
os=OperatingSystem.LINUX,
200202
package_type="libtorch",

.github/workflows/_runner-determinator.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ on:
4040

4141
jobs:
4242
runner-determinator:
43+
# Don't run on forked repos
44+
if: github.repository_owner == 'pytorch'
4345
runs-on: ubuntu-latest
4446
outputs:
4547
label-type: ${{ steps.set-condition.outputs.label-type }}

.github/workflows/build-libtorch-images.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
runs-on: "${{ needs.get-label-type.outputs.label-type }}linux.9xlarge.ephemeral"
4545
strategy:
4646
matrix:
47-
cuda_version: ["12.4", "12.1", "11.8"]
47+
cuda_version: ["12.6", "12.4", "12.1", "11.8"]
4848
env:
4949
GPU_ARCH_TYPE: cuda
5050
GPU_ARCH_VERSION: ${{ matrix.cuda_version }}

.github/workflows/build-manywheel-images.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
runs-on: "${{ needs.get-label-type.outputs.label-type }}linux.9xlarge.ephemeral"
4949
strategy:
5050
matrix:
51-
cuda_version: ["12.4", "12.1", "11.8"]
51+
cuda_version: ["12.6", "12.4", "12.1", "11.8"]
5252
env:
5353
GPU_ARCH_TYPE: cuda
5454
GPU_ARCH_VERSION: ${{ matrix.cuda_version }}

.github/workflows/generated-linux-binary-manywheel-split-main.yml

Lines changed: 0 additions & 182 deletions
This file was deleted.

0 commit comments

Comments
 (0)