Skip to content

Commit 1e248ca

Browse files
malfetfacebook-github-bot
authored andcommitted
[CircleCI] Use canary images until VC++ 14.27 issue is resolved (#43220)
Summary: Should fix binary build issue on Windows, and promptly error out if images are updated to a different version of VC++ Pull Request resolved: #43220 Reviewed By: ezyang Differential Revision: D23198530 Pulled By: malfet fbshipit-source-id: 0c80361ad7dcfb7aaffccc306b7d741671bedc11
1 parent bc0e1e8 commit 1e248ca

File tree

4 files changed

+6
-54
lines changed

4 files changed

+6
-54
lines changed

.circleci/config.yml

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ executors:
2323
windows-with-nvidia-gpu:
2424
machine:
2525
resource_class: windows.gpu.nvidia.medium
26-
image: windows-server-2019-nvidia:stable
26+
image: windows-server-2019-nvidia:canary
2727
shell: bash.exe
2828

2929
windows-xlarge-cpu-with-nvidia-cuda:
3030
machine:
3131
resource_class: windows.xlarge
32-
image: windows-server-2019-vs2019:stable
32+
image: windows-server-2019-vs2019:canary
3333
shell: bash.exe
3434

3535
windows-medium-cpu-with-nvidia-cuda:
3636
machine:
3737
resource_class: windows.medium
38-
image: windows-server-2019-vs2019:stable
38+
image: windows-server-2019-vs2019:canary
3939
shell: bash.exe
4040
commands:
4141

@@ -672,13 +672,6 @@ jobs:
672672
executor: <<parameters.executor>>
673673
steps:
674674
- checkout
675-
- run:
676-
name: Install VS 14.26 toolchain
677-
no_output_timeout: 30m
678-
command: |
679-
if [[ "${VC_VERSION}" == "14.26" ]]; then
680-
powershell .circleci/scripts/windows_vs_14_26_install.ps1
681-
fi
682675
- run:
683676
name: Install Cuda
684677
no_output_timeout: 30m
@@ -743,13 +736,6 @@ jobs:
743736
- checkout
744737
- attach_workspace:
745738
at: c:/users/circleci/workspace
746-
- run:
747-
name: Install VS 14.26 toolchain
748-
no_output_timeout: 30m
749-
command: |
750-
if [[ "${VC_VERSION}" == "14.26" ]]; then
751-
powershell .circleci/scripts/windows_vs_14_26_install.ps1
752-
fi
753739
- run:
754740
name: Install Cuda
755741
no_output_timeout: 30m

.circleci/scripts/windows_vs_14_26_install.ps1

Lines changed: 0 additions & 20 deletions
This file was deleted.

.circleci/verbatim-sources/header-section.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ executors:
2323
windows-with-nvidia-gpu:
2424
machine:
2525
resource_class: windows.gpu.nvidia.medium
26-
image: windows-server-2019-nvidia:stable
26+
image: windows-server-2019-nvidia:canary
2727
shell: bash.exe
2828

2929
windows-xlarge-cpu-with-nvidia-cuda:
3030
machine:
3131
resource_class: windows.xlarge
32-
image: windows-server-2019-vs2019:stable
32+
image: windows-server-2019-vs2019:canary
3333
shell: bash.exe
3434

3535
windows-medium-cpu-with-nvidia-cuda:
3636
machine:
3737
resource_class: windows.medium
38-
image: windows-server-2019-vs2019:stable
38+
image: windows-server-2019-vs2019:canary
3939
shell: bash.exe

.circleci/verbatim-sources/job-specs/pytorch-job-specs.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,6 @@ jobs:
220220
executor: <<parameters.executor>>
221221
steps:
222222
- checkout
223-
- run:
224-
name: Install VS 14.26 toolchain
225-
no_output_timeout: 30m
226-
command: |
227-
if [[ "${VC_VERSION}" == "14.26" ]]; then
228-
powershell .circleci/scripts/windows_vs_14_26_install.ps1
229-
fi
230223
- run:
231224
name: Install Cuda
232225
no_output_timeout: 30m
@@ -291,13 +284,6 @@ jobs:
291284
- checkout
292285
- attach_workspace:
293286
at: c:/users/circleci/workspace
294-
- run:
295-
name: Install VS 14.26 toolchain
296-
no_output_timeout: 30m
297-
command: |
298-
if [[ "${VC_VERSION}" == "14.26" ]]; then
299-
powershell .circleci/scripts/windows_vs_14_26_install.ps1
300-
fi
301287
- run:
302288
name: Install Cuda
303289
no_output_timeout: 30m

0 commit comments

Comments
 (0)