Use Ruff formatter in devcontainer config#3737
Merged
vfdev-5 merged 4 commits intopytorch:masterfrom Apr 15, 2026
Merged
Conversation
Collaborator
aaishwarymishra
left a comment
aaishwarymishra
left a comment
There was a problem hiding this comment.
sorry I listed wrong extension id in the issue.
| "ms-python.python", | ||
| "charliermarsh.ruff", | ||
| "ms-python.black-formatter" | ||
| "astral-sh.ruff" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "astral-sh.ruff" | |
| "charliermarsh.ruff" |
| "python.testing.pytestEnabled": true, | ||
| "[python]": { | ||
| "editor.defaultFormatter": "ms-python.black-formatter" | ||
| "editor.defaultFormatter": "astral-sh.ruff" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "editor.defaultFormatter": "astral-sh.ruff" | |
| "editor.defaultFormatter": "charliermarsh.ruff" |
Collaborator
|
I just noticed that there are few settings for black in the |
Contributor
Author
|
Updated the PR to use the requested Ruff extension ID, removed the stale Black formatter config from |
Collaborator
|
formatting is not correct, I think you forgot to run pre-commit hook |
Contributor
Author
|
Ran pre-commit and pushed the formatting fix in 1efd74f. Waiting on workflow approval for CI to rerun. |
Collaborator
|
@vfdev-5 I think this can be merged. |
vfdev-5
reviewed
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3736
Description:
ms-python.black-formatterwithastral-sh.ruffin.devcontainer/devcontainer.jsonCheck list: