Add min_evals parameter to EarlyStopping handler#3661
Open
D0-T wants to merge 2 commits intopytorch:masterfrom
Open
Add min_evals parameter to EarlyStopping handler#3661D0-T wants to merge 2 commits intopytorch:masterfrom
D0-T wants to merge 2 commits intopytorch:masterfrom
Conversation
Introduces a warmup period by adding a new min_evals parameter to EarlyStopping. When specified, the handler skips patience enforcement until it has been called at least min_evals times. Addresses: pytorch#3411
Collaborator
|
@vfdev-5 What do you think? like pr has some problems but should we add helper function like discussed in the issue or add it as parameter so I can ask for refactoring? |
Collaborator
|
I think let's finish first with #3619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3411
Description:
Adds a 'min_evals' parameter to 'EarlyStopping' to implement a warmup period.
When specified, the handler tracks the best score but does not enforce patience
until it has been called at least 'min_evals' times.
Changes:
Check list: