Skip to content

refactor super() in ignite/metrics#3551

Merged
vfdev-5 merged 4 commits intopytorch:masterfrom
omkar-334:super-ignite-metrics
Feb 25, 2026
Merged

refactor super() in ignite/metrics#3551
vfdev-5 merged 4 commits intopytorch:masterfrom
omkar-334:super-ignite-metrics

Conversation

@omkar-334
Copy link
Copy Markdown
Contributor

@omkar-334 omkar-334 commented Feb 19, 2026

Part of #3547

@github-actions github-actions bot added the module: metrics Metrics module label Feb 19, 2026
@omkar-334
Copy link
Copy Markdown
Contributor Author

omkar-334 commented Feb 19, 2026

I have to check ignite/metrics/vision/object_detection_average_precision_recall.py, ignite/metrics/mean_average_precision.py and ignite/metrics/metric.py again, revert a few changes

@omkar-334
Copy link
Copy Markdown
Contributor Author

omkar-334 commented Feb 22, 2026

@vfdev-5 i've fixed the errors for this. can you run the tests?

@aaishwarymishra
Copy link
Copy Markdown
Collaborator

aaishwarymishra commented Feb 23, 2026

@omkar-334
Hello I viewed your pr it looks good, can you squash your commits? There are few unnecessary commit messages.
Also I think there are too many files for 1 pr.

@omkar-334 omkar-334 force-pushed the super-ignite-metrics branch from a9fb514 to c76206c Compare February 24, 2026 07:11
@omkar-334
Copy link
Copy Markdown
Contributor Author

omkar-334 commented Feb 24, 2026

@omkar-334
Hello I viewed your pr it looks good, can you squash your commits? There are few unnecessary commit messages.

Thanks @aaishwarymishra . I think while merging, we have an option to squash and merge right? the message could be changed at that point then.

@aaishwarymishra
Copy link
Copy Markdown
Collaborator

aaishwarymishra commented Feb 24, 2026

@vfdev-5 this pr looks fine can you check it please

vfdev-5
vfdev-5 approved these changes Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omkar-334 and @aaishwarymishra !

@vfdev-5 vfdev-5 enabled auto-merge February 25, 2026 09:10
@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 25, 2026
Merged via the queue into pytorch:master with commit 17efea7 Feb 25, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omkar-334 @aaishwarymishra @vfdev-5