Update type hints in accumulation.py to PEP 604 syntax#3518
Merged
Conversation
Co-authored-by: vfdev-5 <[email protected]>
Co-authored-by: vfdev-5 <[email protected]>
Copilot
AI
changed the title
[WIP] Update old typing hints in ignite/metrics
Update type hints in accumulation.py to PEP 604 syntax
Feb 6, 2026
vfdev-5
reviewed
Feb 6, 2026
Co-authored-by: vfdev-5 <[email protected]>
vfdev-5
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes type hints in
ignite/metrics/accumulation.pyto use Python 3.10+ union syntax per issue #3481.Changes
Union[A, B]→A | B(11 instances)Tuple[...]→tuple[...](1 instance)Union,TupleimportsExample
Affects
VariableAccumulation,Average, andGeometricAverageclasses.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.