Fix error message typo and remove redundant type casts#3503
Merged
Conversation
- Remove Union import (no longer needed) - Replace Union[str, torch.device] with str | torch.device - Replace Union[float, torch.Tensor] with float | torch.Tensor Co-authored-by: vfdev-5 <[email protected]>
Copilot
AI
changed the title
[WIP] Update old typing hints in ignite metrics
Modernize type hints in mean_pairwise_distance.py to Python 3.10+ syntax
Feb 3, 2026
vfdev-5
approved these changes
Feb 3, 2026
Co-authored-by: vfdev-5 <[email protected]>
- Remove redundant cast() calls on lines 95 and 98 - Remove unused 'cast' import from typing - Type annotation on function signature already provides type safety Co-authored-by: vfdev-5 <[email protected]>
Copilot
AI
changed the title
Modernize type hints in mean_pairwise_distance.py to Python 3.10+ syntax
Fix error message typo and remove redundant type casts
Feb 3, 2026
vfdev-5
approved these changes
Feb 3, 2026
Update the expected error message in test to match the fix made to MeanPairwiseDistance.compute() where "MeanAbsoluteError" was corrected to "MeanPairwiseDistance". Co-authored-by: vfdev-5 <[email protected]>
auto-merge was automatically disabled
February 3, 2026 09:12
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review findings and Pyrefly warnings in metrics module.
Error Message Correction
MeanPairwiseDistance.compute()raisedNotComputableErrorwith incorrect class name reference:Updated corresponding test expectation in
test_mean_pairwise_distance.py::test_zero_sample.Redundant Cast Removal
Removed unnecessary
cast()calls inLoss.update()where function signature already provides type narrowing:Removed unused
castimport fromtyping.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.