Update loss.py type hints to Python 3.10+ syntax#3501
Merged
Conversation
Co-authored-by: vfdev-5 <[email protected]>
Co-authored-by: vfdev-5 <[email protected]>
Copilot
AI
changed the title
[WIP] Update typing hints in ignite metrics
Update loss.py type hints to Python 3.10+ syntax
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize type hints in
ignite/metrics/loss.pyto use PEP 604 union syntax and built-in generics, aligning with Python 3.10+ (now minimum supported version).Changes
Union[str, torch.device]→str | torch.deviceTuple[...]→tuple[...]Dict→dictupdate()signature fromSequence[Union[torch.Tensor, Dict]]totuple[torch.Tensor, torch.Tensor] | tuple[torch.Tensor, torch.Tensor, dict]for better type safetyPart of ongoing effort to modernize typing across the codebase.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.