Skip to content

Refactor type hints in median_absolute_error.py#3498

Merged
vfdev-5 merged 2 commits intopytorch:masterfrom
leelakrishnaRajasimha:master
Jan 27, 2026
Merged

Refactor type hints in median_absolute_error.py#3498
vfdev-5 merged 2 commits intopytorch:masterfrom
leelakrishnaRajasimha:master

Conversation

@leelakrishnaRajasimha
Copy link
Copy Markdown
Contributor

@leelakrishnaRajasimha leelakrishnaRajasimha commented Jan 24, 2026

This PR refractors type hints in
'ignite/metrics/regression/median_absolute_error.py'
to use Python 3.10+ syntax.

Related to #3481

@github-actions github-actions bot added the module: metrics Metrics module label Jan 24, 2026
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 vfdev-5 enabled auto-merge January 24, 2026 15:24
@vfdev-5 vfdev-5 disabled auto-merge January 24, 2026 16:16
@leelakrishnaRajasimha
Copy link
Copy Markdown
Contributor Author

I have fixed the code style formatting issues. Ready for the checks to run.

@github-actions github-actions bot added the module: handlers Core Handlers module label Jan 25, 2026
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Jan 26, 2026

@leelakrishnaRajasimha this PR #3500 should fix the pyrefly problem. Once it is merged can you rebase your PR on it and we can rerun the CI.
Thanks for working on your PR!

@leelakrishnaRajasimha
Copy link
Copy Markdown
Contributor Author

Hi @vfdev-5 , just a quick update: I have successfully rebased this branch and resolved the merge conflicts. It now includes the fixes from PR #3500.
The checks should be ready to run again. Thanks for the guidance on this.

Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vfdev-5 vfdev-5 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into pytorch:master with commit c85dce5 Jan 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: handlers Core Handlers module module: metrics Metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants