Add typing and style checks as separate workflows#3442
Merged
vfdev-5 merged 1 commit intopytorch:masterfrom Sep 5, 2025
Merged
Add typing and style checks as separate workflows#3442vfdev-5 merged 1 commit intopytorch:masterfrom
vfdev-5 merged 1 commit intopytorch:masterfrom
Conversation
Collaborator
|
@goanpeca should we also remove mypy check step from unit-tests.yml: ignite/.github/workflows/unit-tests.yml Lines 100 to 105 in 400973d |
Collaborator
Author
Yes I will remove that! |
goanpeca
force-pushed
the
enh/checks
branch
2 times, most recently
from
00318bd to
f968747
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request separates typing and style checks into dedicated GitHub Actions workflows, moving them out of the main unit test workflow to improve CI organization and performance.
- Removes code formatting and MyPy checks from the unit test workflow
- Creates a new dedicated typing checks workflow that runs MyPy on multiple Python versions
- Replaces the automatic code formatting workflow with a code style checks workflow that validates formatting without auto-fixing
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/unit-tests.yml | Removes code formatting and MyPy type checking steps |
| .github/workflows/typing-checks.yml | New workflow for running MyPy type checking on Python 3.9 and 3.13 |
| .github/workflows/code-style.yml | Removes the old automatic code formatting workflow |
| .github/workflows/code-style-checks.yml | New workflow for validating code style without auto-fixing |
| ignite/handlers/clearml_logger.py | Adds type annotations and type ignore comments for MyPy compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typing and style checks as separate workflows