Skip to content

Update docker images#3430

Merged
vfdev-5 merged 1 commit intopytorch:masterfrom
goanpeca:enh/update-docker-images
Jul 7, 2025
Merged

Update docker images#3430
vfdev-5 merged 1 commit intopytorch:masterfrom
goanpeca:enh/update-docker-images

Conversation

@goanpeca
Copy link
Copy Markdown
Collaborator

@goanpeca goanpeca commented Jun 18, 2025 •
edited
Loading

  • Update docker images
  • Fixes Horovod build with latest stable version.

@github-actions github-actions bot added the ci CI label Jul 7, 2025
@goanpeca goanpeca force-pushed the enh/update-docker-images branch from 709a7fe to 51b147e Compare July 7, 2025 03:38
@goanpeca goanpeca marked this pull request as ready for review July 7, 2025 03:51
@goanpeca
Copy link
Copy Markdown
Collaborator Author

goanpeca commented Jul 7, 2025 •
edited
Loading

Hi @vfdev-5, I think this one is ready for review :)

Should I check if everything builds with cuda 12.8 and update to use that? 🤔

@goanpeca goanpeca mentioned this pull request Jul 7, 2025
Closed
vfdev-5
vfdev-5 reviewed Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gonzalo!
I left a comment and questions

@goanpeca goanpeca force-pushed the enh/update-docker-images branch 2 times, most recently from d36da9c to 9fc9f5d Compare July 7, 2025 11:56
vfdev-5
vfdev-5 reviewed Jul 7, 2025
View reviewed changes
docker/docker.cfg Outdated
@@ -1,4 +1,4 @@
[DEFAULT]
build_docker_image_pytorch_version = 2.6.0-cuda12.4-cudnn9
build_docker_image_pytorch_version = 2.7.1-cuda12.8-cudnn9
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was on purpose to keep not too recent cuda version as user's host machine driver may not be that recent and this would require to upgrade the drivers etc to use the image.
If we can set it to 12.4 it is good, if pytorch image has 12.6 as minimal version, let's use that.

Copy link
Copy Markdown
Collaborator Author

@goanpeca goanpeca Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 for the 2.7.1 version we have images with

2.7.1-cuda11.8-cudnn9-...
2.7.1-cuda12.6-cudnn9-...
2.7.1-cuda12.8-cudnn9-...

So minimal version is 11.8 for the pytroch images.

Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11.8 is rather old, let's use 12.6

vfdev-5
vfdev-5 reviewed Jul 7, 2025
View reviewed changes
@goanpeca goanpeca force-pushed the enh/update-docker-images branch from 0ba9654 to c1b6fdd Compare July 7, 2025 12:22
@goanpeca goanpeca force-pushed the enh/update-docker-images branch from c1b6fdd to 7e5bb82 Compare July 7, 2025 12:24
@goanpeca goanpeca requested a review from vfdev-5 July 7, 2025 12:29
vfdev-5
vfdev-5 approved these changes Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gonzalo!

@vfdev-5 vfdev-5 merged commit 72fede0 into pytorch:master Jul 7, 2025
9 checks passed
@goanpeca goanpeca deleted the enh/update-docker-images branch July 7, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

ci CI docker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goanpeca @vfdev-5