Skip to content

adds argument name for device in test_mean_squared_error #3335#3351

Merged
vfdev-5 merged 3 commits intopytorch:masterfrom
BanzaiTokyo:test_mean_squared_error_missing_device
Mar 25, 2025
Merged

adds argument name for device in test_mean_squared_error #3335#3351
vfdev-5 merged 3 commits intopytorch:masterfrom
BanzaiTokyo:test_mean_squared_error_missing_device

Conversation

@BanzaiTokyo
Copy link
Copy Markdown
Contributor

missing argument name for device when instantiating MeanSquaredError

Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @BanzaiTokyo !

@BanzaiTokyo BanzaiTokyo requested a review from vfdev-5 March 25, 2025 21:50
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 25, 2025 21:52
@vfdev-5 vfdev-5 merged commit ef8d912 into pytorch:master Mar 25, 2025
14 checks passed
@BanzaiTokyo BanzaiTokyo deleted the test_mean_squared_error_missing_device branch March 26, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants