Skip to content

Update test_average_precision.py to resolve issue #3335#3337

Merged
vfdev-5 merged 4 commits intopytorch:masterfrom
puhuk:test_average_precision_device
Feb 28, 2025
Merged

Update test_average_precision.py to resolve issue #3335#3337
vfdev-5 merged 4 commits intopytorch:masterfrom
puhuk:test_average_precision_device

Conversation

@puhuk
Copy link
Copy Markdown
Contributor

@puhuk puhuk commented Feb 27, 2025 •
edited by vfdev-5
Loading

Related to #3335

Description: Resolved the issue with test_average_precision.py when running in distributed mode, as reported in #3335.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5
vfdev-5 reviewed Feb 27, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Feb 27, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Feb 27, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @puhuk
I left few comments how to make it better

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 27, 2025

Let's keep track of https://github.com/pytorch/ignite/actions/runs/13568080551/job/37925851877?pr=3337 job and see whether there are related failing tests. If some related tests are failing we need to provide a fix in this PR.

@puhuk
Copy link
Copy Markdown
Contributor Author

puhuk commented Feb 27, 2025

Let's keep track of https://github.com/pytorch/ignite/actions/runs/13568080551/job/37925851877?pr=3337 job and see whether there are related failing tests. If some related tests are failing we need to provide a fix in this PR.

Got it! Keeping an eye on it! If anything breaks, I’ll be ready to fix it. 🚀

@puhuk
Copy link
Copy Markdown
Contributor Author

puhuk commented Feb 28, 2025

@vfdev-5
I have a question regarding the mps-tests. It reports an error in test_precision.
Why does this error occur even though I only modified test_average_precision?
Are you suggesting that test_precision should also be fixed in this PR?

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 28, 2025

@vfdev-5 I have a question regarding the mps-tests. It reports an error in test_precision. Why does this error occur even though I only modified test_average_precision? Are you suggesting that test_precision should also be fixed in this PR?

This should be done in #3334
which is almost finished (remains one failure in one test). Once that PR is merged you can rebase your PR on the master and the unrelated failures should disappear.

vfdev-5
vfdev-5 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk ! LGTM

@vfdev-5 vfdev-5 enabled auto-merge (squash) February 28, 2025 14:16
@vfdev-5 vfdev-5 merged commit 6401a59 into pytorch:master Feb 28, 2025
13 of 14 checks passed
@puhuk puhuk deleted the test_average_precision_device branch February 28, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@puhuk @vfdev-5