Skip to content

Use f32 for metrics on mps#3334

Merged
vfdev-5 merged 6 commits intomasterfrom
use-f32-for-mps-metrics
Feb 28, 2025
Merged

Use f32 for metrics on mps#3334
vfdev-5 merged 6 commits intomasterfrom
use-f32-for-mps-metrics

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Feb 26, 2025

Description:

  • Use f32 dtype for double dtype in metrics on MPS device

Fixes #3326

@github-actions github-actions bot added the module: metrics Metrics module label Feb 26, 2025
@vfdev-5 vfdev-5 force-pushed the use-f32-for-mps-metrics branch from e81aed3 to 474ef40 Compare February 27, 2025 22:03
@vfdev-5 vfdev-5 marked this pull request as ready for review February 27, 2025 22:03
@vfdev-5 vfdev-5 changed the title Use f32 for mps metrics Use f32 for metrics on mps Feb 27, 2025
@vfdev-5 vfdev-5 force-pushed the use-f32-for-mps-metrics branch from 474ef40 to 42c0ea9 Compare February 27, 2025 22:15
@vfdev-5 vfdev-5 force-pushed the use-f32-for-mps-metrics branch from e0d6a93 to b162384 Compare February 28, 2025 12:30
@vfdev-5 vfdev-5 enabled auto-merge (squash) February 28, 2025 12:39
@vfdev-5 vfdev-5 merged commit cd1033c into master Feb 28, 2025
17 of 20 checks passed
@vfdev-5 vfdev-5 deleted the use-f32-for-mps-metrics branch February 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI module: metrics Metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics computation on pytorch MPS backend fails, needs float32 instead of float64

1 participant