Fix deprecated statement by Gulin7 · Pull Request #3307 · pytorch/ignite

Gulin7 · 2024-11-27T07:07:51Z

Fixes #3304

Description:
Replaced all occurances of torch.cuda.amp.autocast with torch.amp.autocast('cuda',...)

Replaced torch.cuda.amp.autocast with torch.amp.autocast("cuda",...).

vfdev-5

Thanks for the PR @Gulin7
I left few comments to address

examples/notebooks/CycleGAN_with_torch_cuda_amp.ipynb

examples/references/segmentation/pascal_voc2012/main.py

examples/transformers/main.py

ignite/engine/__init__.py

tests/ignite/engine/test_create_supervised.py

Gulin7 · 2024-11-28T10:02:33Z

@vfdev-5 I addressed your comments, tag me and let me know if there is anything else that needs improvement.

ignite/metrics/kl_divergence.py

ignite/metrics/js_divergence.py

vfdev-5 · 2024-11-28T10:30:47Z

Some tests are failing as well: https://github.com/pytorch/ignite/actions/runs/12045408777/job/33647387903

vfdev-5 · 2024-11-28T10:31:49Z

examples/notebooks/CycleGAN_with_torch_cuda_amp.ipynb

@@ -1,31 +1,4 @@
 {
- "nbformat": 4,


Can you please make just necessary changes without all unrelated updates?

ignite/engine/__init__.py

tests/ignite/engine/test_create_supervised.py

vfdev-5 · 2024-12-02T22:22:39Z

@Gulin7 there is a failing test with error message:


=========================== short test summary info ============================
FAILED tests/ignite/engine/test_create_supervised.py::test_create_supervised_trainer_amp_error - AssertionError: Regex pattern did not match.
 Regex: 'Please install torch>=1.12.0 to use scaler argument.'
 Input: "Please install torch>=1.12.0 to use amp_mode='amp'."
======================== 1 failed, 3 warnings in 2.71s =========================

and also there is this comment to address: #3307 (comment)

Can you please fix them? Thanks!

tests/ignite/engine/test_create_supervised.py

ignite/engine/__init__.py

tests/ignite/engine/test_create_supervised.py

vfdev-5

LGTM

Gulin7 and others added 2 commits November 27, 2024 09:05

fix-deprecated-warning

99d807a

Replaced torch.cuda.amp.autocast with torch.amp.autocast("cuda",...).

autopep8 fix

52f5154

github-actions bot added module: engine Engine module examples Examples labels Nov 27, 2024