Merged
Conversation
3 tasks
vfdev-5
reviewed
Oct 14, 2024
Collaborator
|
@kzkadc can you please also update this metric implementation https://github.com/pytorch/ignite/blob/master/ignite/metrics/precision_recall_curve.py according to the way we are now doing everywhere else (in a separate PR). Thanks! |
3 tasks
Contributor
Author
|
@vfdev-5 could you recheck this PR again? |
vfdev-5
approved these changes
Oct 14, 2024
Collaborator
There was a problem hiding this comment.
LGTM, thanks a lot @kzkadc !
Let's see if CI is green to land it.
EDIT:
Unrelated failures with mypy:
+ mypy --config-file mypy.ini
ignite/metrics/fbeta.py:154: error: Unused "type: ignore" comment
[unused-ignore]
output_transform=(lambda x: x) if output_transform is None...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/metrics/fbeta.py:163: error: Unused "type: ignore" comment
[unused-ignore]
output_transform=(lambda x: x) if output_transform is None...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ignite/handlers/time_profilers.py:420: error: Incompatible types in string
interpolation (expression has type "str", placeholder has type "int | float")
[str-format]
output_message = """
^
Found 3 errors in 2 files (checked 151 source files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: added metrics for evaluating clustering results implemented in scikit-learn:
Check list: