Merged
Conversation
3 tasks
Contributor
Author
|
@vfdev-5 |
Collaborator
|
@kzkadc please check mypy failure: |
vfdev-5
reviewed
Sep 20, 2024
Collaborator
|
@kzkadc some distributed tests are failing: =========================== short test summary info ============================
FAILED tests/ignite/metrics/test_hsic.py::TestDistributed::test_integration[gloo_cpu--1.0-1.0] - assert 3.780633494340978e-05 ± 2.0e-05 == 2.1274586519148087e-31
comparison failed
Obtained: 2.1274586519148087e-31
Expected: 3.780633494340978e-05 ± 2.0e-05
FAILED tests/ignite/metrics/test_hsic.py::TestDistributed::test_integration[gloo_cpu-1.0--1.0] - assert 3.780633494340978e-05 ± 2.0e-05 == 5.500369049116216e-11
comparison failed
Obtained: 5.500369049116216e-11
Expected: 3.780633494340978e-05 ± 2.0e-05
FAILED tests/ignite/metrics/test_hsic.py::TestDistributed::test_integration[gloo_cpu-1.0-1.0] - assert 3.780633494340978e-05 ± 2.0e-05 == 3.3436754842126586e-39
comparison failed
Obtained: 3.3436754842126586e-39
Expected: 3.780633494340978e-05 ± 2.0e-05
========== 3 failed, 2 skipped, 3133 deselected, 2 warnings in 7.72s ===========I haven't checked in details why, but from the first glance something looks weird in the output values which are almost zeros and expected is just close to zero. Any ideas why this happens? |
This reverts commit cb71355.
Contributor
Author
|
I'm struggling with the numerical errors and have been checking the code, but I'm not sure why it happens for now. |
vfdev-5
reviewed
Sep 23, 2024
vfdev-5
reviewed
Sep 23, 2024
vfdev-5
reviewed
Sep 23, 2024
Contributor
Author
|
@vfdev-5 Thank you for fixing the test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: added Hilbert-Schmidt Independence Criterion (HSIC).
HSIC is a kernel-based method to measure the statistical independence between two feature vectors:
https://papers.nips.cc/paper_files/paper/2007/hash/d5cfead94f5350c12c322b5b664544c1-Abstract.html
https://jejjohnson.github.io/research_journal/appendix/similarity/hsic/
This metric computes the unbiased estimator of the HSIC proposed in the following:
https://jmlr.csail.mit.edu/papers/v13/song12a.html
Check list: