Skip to content

Fixed mypy failure on the CI#3279

Merged
vfdev-5 merged 1 commit intovfdev-5-patch-1from
fix-ci-mypy-wandb
Sep 3, 2024
Merged

Fixed mypy failure on the CI#3279
vfdev-5 merged 1 commit intovfdev-5-patch-1from
fix-ci-mypy-wandb

Conversation

@vfdev-5
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 commented Sep 3, 2024 •
edited
Loading

Description:

  • Fixed mypy failure on the CI
Run bash ./tests/run_code_style.sh mypy
+ '[' mypy = lint ']'
+ '[' mypy = fmt ']'
+ '[' mypy = mypy ']'
+ mypy --config-file mypy.ini
ignite/handlers/wandb_logger.py:144: error: Module has no attribute "finish" 
[attr-defined]
            self._wandb.finish()
            ^~~~~~~~~~~~~~~~~~
Found 1 error in 1 file (checked 145 source files)

@github-actions github-actions bot added the module: handlers Core Handlers module label Sep 3, 2024
@vfdev-5 vfdev-5 changed the base branch from master to vfdev-5-patch-1 September 3, 2024 16:15
@vfdev-5 vfdev-5 merged commit b2f18b0 into vfdev-5-patch-1 Sep 3, 2024
@vfdev-5 vfdev-5 deleted the fix-ci-mypy-wandb branch September 3, 2024 16:20
vfdev-5 added a commit that referenced this pull request Sep 3, 2024
@vfdev-5
Temporary pinned mlflow version to fix the failing CI (#3278)
e21baf9 
* Pinned mlflow version

* Fixed mypy failure on the CI (#3279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module: handlers Core Handlers module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vfdev-5