Skip to content

Fix failing Pytorch version tests CI#3267

Merged
vfdev-5 merged 2 commits intopytorch:masterfrom
simeetnayan81:master
Jul 30, 2024
Merged

Fix failing Pytorch version tests CI#3267
vfdev-5 merged 2 commits intopytorch:masterfrom
simeetnayan81:master

Conversation

@simeetnayan81
Copy link
Copy Markdown
Contributor

@simeetnayan81 simeetnayan81 commented Jul 30, 2024 •
edited by vfdev-5
Loading

Description:

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Jul 30, 2024

@simeetnayan81 Thanks for the PR, if this works let's remove all commented lines:

# temporary fix for python=3.12 and v3.8.1
# nltk
# git+https://github.com/nltk/nltk

vfdev-5
vfdev-5 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other CI failures are unrelated

@vfdev-5 vfdev-5 merged commit 2ac34be into pytorch:master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simeetnayan81 @vfdev-5