Merged
Conversation
Contributor
Author
|
This is just an initial PR. I am currently working on the remaining classes. |
…st_cosine_similarity
…aximum_mean_discrepancy.py
…cy.py and test_mean_pairwise_distance.py
…usion_matrix.py, test_multilabel_confusion_matrix.py
vfdev-5
reviewed
Jul 16, 2024
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR with all those meticulous updates!
I left few comments to improve it.
Contributor
Author
|
I don't think these classes require skip_unrolling feature. Lmk. |
Collaborator
|
Yes, we can skip GpuInfo and MetricsLambda, but we still need to add it to Frequency for consistency. |
Contributor
Author
|
Have updated the Frequency class as well. Args were missing in docstring, added them. |
vfdev-5
approved these changes
Jul 16, 2024
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for the PR, @simeetnayan81 !
Good to go once the CI is green (as we ignore failing TPU test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Follow up PR for adding argument skip_unrolling in Metric Class. #3258
Following classes need to be updated:
Modification might also be required to related classes.
Check list: