Skip to content

fix scheduled tests#3253

Closed
leej3 wants to merge 1 commit intopytorch:masterfrom
leej3:fix-missing-pytest-on-scheduled-tests
Closed

fix scheduled tests#3253
leej3 wants to merge 1 commit intopytorch:masterfrom
leej3:fix-missing-pytest-on-scheduled-tests

Conversation

@leej3
Copy link
Copy Markdown
Contributor

@leej3 leej3 commented May 29, 2024

This should fix the failing scheduled tests. Pytest isn't found for them. These tests use the setup-miniconda action for python env installation. The action needs a bash login shell in subsequent steps for the env to be active.

Here's a description of the problem: https://stackoverflow.com/questions/72703363/how-to-activate-conda-environment-in-github-actions

Also torch.backends.mps does not exist for older pytorch versions and "filelock" should be listed explicitly as a dependency.

add better error message when pytest is not on the PATH
@leej3 leej3 requested a review from vfdev-5 May 29, 2024 08:49
@github-actions github-actions bot added the ci CI label May 29, 2024
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented May 29, 2024

@leej3 leej3 mentioned this pull request May 29, 2024
@leej3 leej3 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants