improve type support for fbrlogger#3238
Merged
vfdev-5 merged 7 commits intopytorch:masterfrom Jun 28, 2024
Merged
Conversation
Collaborator
|
@leej3 do you think it is possible to fix the CI here? |
vfdev-5
reviewed
Jun 9, 2024
vfdev-5
force-pushed
the
update-fbrlogger-
branch
from
0ae7ce8 to
f3b437b
Compare
Collaborator
|
@leej3 can you please reopen this PR and change the merging branch to master? EDIT: could finally do that myself |
github-actions
bot
added
module: utils
vfdev-5
reviewed
Jun 19, 2024
leej3
force-pushed
the
fix-type-issue
branch
2 times, most recently
from
1e37dce to
a247969
Compare
vfdev-5
reviewed
Jun 26, 2024
vfdev-5
reviewed
Jun 26, 2024
vfdev-5
approved these changes
Jun 26, 2024
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, just few questions to clarify and we can land it.
Failing tpu jobs is unrelated
Collaborator
|
Thanks for the fixes, John! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.