Skip to content

Fix error in old PyTorch for KL and JS divergence#3236

Merged
vfdev-5 merged 13 commits intopytorch:masterfrom
kzkadc:divergence
Apr 26, 2024
Merged

Fix error in old PyTorch for KL and JS divergence#3236
vfdev-5 merged 13 commits intopytorch:masterfrom
kzkadc:divergence

Conversation

@kzkadc
Copy link
Copy Markdown
Contributor

@kzkadc kzkadc commented Apr 18, 2024

Fixes #3232 (comment)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Apr 18, 2024
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kzkadc !

@vfdev-5 vfdev-5 enabled auto-merge (squash) April 24, 2024 08:36
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Apr 26, 2024

There are unrelated CI failures to fix later, so will be merging this PR.

@vfdev-5 vfdev-5 disabled auto-merge April 26, 2024 20:04
@vfdev-5 vfdev-5 merged commit 565e8be into pytorch:master Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: metrics Metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants