Skip to content

Add cosine similarity metric#3203

Merged
vfdev-5 merged 22 commits intopytorch:masterfrom
kzkadc:cosine_similarity
Mar 19, 2024
Merged

Add cosine similarity metric#3203
vfdev-5 merged 22 commits intopytorch:masterfrom
kzkadc:cosine_similarity

Conversation

@kzkadc
Copy link
Copy Markdown
Contributor

@kzkadc kzkadc commented Mar 14, 2024 •
edited
Loading

Fixes #3202

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5
vfdev-5 reviewed Mar 17, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @kzkadc !
I think we can put this implementation to ignite.metrics instead of contrib metrics as it does not have any 3rd party dependencies.

Let's also write a test to verify the correctness

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Mar 18, 2024

@kzkadc thanks for the update. Let's put this implementation to ignite.metrics instead of contrib metrics

@kzkadc
Copy link
Copy Markdown
Contributor Author

kzkadc commented Mar 18, 2024

@vfdev-5 Thank you for your review! I moved it to igite.metrics.
I will also try to write a test.

vfdev-5
vfdev-5 reviewed Mar 18, 2024
View reviewed changes
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Mar 18, 2024

@kzkadc if auto code-formatting GH action is bothering you, you can disable it from your fork. https://github.com/pytorch/ignite/actions/workflows/code-style.yml

@github-actions github-actions bot added docs module: metrics Metrics module labels Mar 19, 2024
vfdev-5
vfdev-5 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @kzkadc !

@vfdev-5 vfdev-5 enabled auto-merge (squash) March 19, 2024 23:21
@vfdev-5 vfdev-5 merged commit 27deb45 into pytorch:master Mar 19, 2024
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Mar 20, 2024

Hi @kzkadc , sorry, I was too quick to merge this PR which actually has failing xla job: https://github.com/pytorch/ignite/actions/runs/8351321508/job/22859463184
Could you please fix it in a follow-up PR?

@kzkadc kzkadc mentioned this pull request Mar 20, 2024
Merged
3 tasks
@kzkadc
Copy link
Copy Markdown
Contributor Author

kzkadc commented Mar 20, 2024

@vfdev-5 sorry for my mistake. I fixed it in #3213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

docs module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add cosine similarity metric

2 participants

@kzkadc @vfdev-5