Skip to content

Fix failing mps tests#3145

Merged
vfdev-5 merged 6 commits intopytorch:masterfrom
pranavvp16:mps
Nov 27, 2023
Merged

Fix failing mps tests#3145
vfdev-5 merged 6 commits intopytorch:masterfrom
pranavvp16:mps

Conversation

@pranavvp16
Copy link
Copy Markdown
Contributor

Draft PR which fixes distributed tests for mps

@sweep-ai-deprecated
Copy link
Copy Markdown
Contributor

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@pranavvp16 pranavvp16 marked this pull request as ready for review November 27, 2023 17:13
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pranavvp16

CI failures are unrelated.

@vfdev-5 vfdev-5 merged commit 514e2f8 into pytorch:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants