Use class to organize distributed tests in modules#3069
Merged
vfdev-5 merged 1 commit intopytorch:masterfrom Sep 24, 2023
Merged
Conversation
vfdev-5
approved these changes
Sep 24, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @sadra-barikbin , LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already suggested by @vfdev-5
Description:
The gola of the PR is to reduce the number of distributed context setup/destroy calls.
We can either use
distributedfixture per method or write a class like in the PRFor simple test metthods with
distributedfixture, they are instantiated once per method then. It falls back to scope=function for those test items.