Fix a bug in native::_do_all_gather related to group#2947
Merged
vfdev-5 merged 7 commits intopytorch:masterfrom Jun 19, 2023
Conversation
vfdev-5
reviewed
May 17, 2023
…-tensors-with-different-shapes-but-the-same-ndim' into Feature-allgather-tensors-with-different-shapes-but-the-same-ndim
…hapes-but-the-same-ndim
sadra-barikbin
force-pushed
the
Feature-allgather-tensors-with-different-shapes-but-the-same-ndim
branch
from
d156ac3 to
eeda68b
Compare
Collaborator
|
@sadra-barikbin please update PR title and description to match the content |
sadra-barikbin
changed the title
native::_do_all_gather related to group
vfdev-5
approved these changes
Jun 19, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @sadra-barikbin !
sadra-barikbin
deleted the
Feature-allgather-tensors-with-different-shapes-but-the-same-ndim
branch
Collaborator
|
@sadra-barikbin this PR breaks compatibility with previous versions: https://github.com/pytorch/ignite/actions/runs/5317062760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix a bug in
native::_do_all_gatherrelated to group-Improve
idist.all_gatherdocstringCheck list: