Added score_sign to add_early_stopping_by_val_score and gen_save_best_models_by_val_score#2929
Merged
vfdev-5 merged 8 commits intopytorch:masterfrom Apr 26, 2023
Merged
Conversation
Hummer12007
force-pushed
the
patch-1
branch
2 times, most recently
from
ddb9378 to
04d3de1
Compare
vfdev-5
reviewed
Apr 25, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR @Hummer12007 and sorry for delay!
Let's see if CI is passing, otherwise looks good to me
Collaborator
|
@Hummer12007 seems like code formatting checker is not happy. Please run the following locally and update the PR: |
Co-authored-by: vfdev <[email protected]>
vfdev-5
approved these changes
Apr 26, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @Hummer12007 !
vfdev-5
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: added a score_sign argument to add_early_stopping_by_val_score to support easy setup of early stopping by loss.
Check list: