Added every_before_after event filter#2860
Merged
vfdev-5 merged 11 commits intopytorch:masterfrom Feb 14, 2023
Merged
Conversation
* Executes after every `every` Iterations * For after=8, before=25, every=5 Executes on Iterations 9 14 19 24
vfdev-5
reviewed
Feb 10, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
@theory-in-progress thanks for the PR ! Please add tests, I think args checking wont pass
* Raise Error condition according to the addition of the new feature of every iterations
* Edited the Function name of every_before_and_after_event_filter
* Added all the variations that can be passed as arguments, using for loops * Added test for every_before_and_after feature
vfdev-5
reviewed
Feb 13, 2023
theory-in-progress
force-pushed
the
master
branch
from
1d069c6 to
e5c60af
Compare
vfdev-5
reviewed
Feb 13, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the update @theory-in-progress
I left few comments
vfdev-5
reviewed
Feb 14, 2023
vfdev-5
reviewed
Feb 14, 2023
vfdev-5
approved these changes
Feb 14, 2023
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR @theory-in-progress ! LGTM
This was referenced Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2853
Description:
everyIterationsCheck list: