Add model_transform in create supervised trainer by guptaaryan16 · Pull Request #2848 · pytorch/ignite

guptaaryan16 · 2023-02-04T11:31:05Z

Description: I have added the function for model_transform

Check list:

New tests are added (if a new feature is added)
New doc strings: description and/or example code are in RST format
Documentation is updated (if required)

vfdev-5

@guptaaryan16 thanks for the PR ! Looks good to me. Just few minor improvements and please add a test into https://github.com/pytorch/ignite/blob/master/tests/ignite/engine/test_create_supervised.py

ignite/engine/__init__.py

vfdev-5 · 2023-02-04T14:53:23Z

cc @david-waterworth if case if you would like to review this PR

tests/ignite/engine/test_create_supervised.py

vfdev-5 · 2023-02-08T11:31:09Z

@guptaaryan16 thanks for the update but let's improve test code

ignite/engine/__init__.py

vfdev-5 · 2023-02-14T13:09:46Z

@guptaaryan16 can you please update this PR to make it merged

guptaaryan16 · 2023-02-14T13:42:16Z

Hey @vfdev-5 , sure I am making the changes by today or tomorrow EOD and I apologise for the delay in the same

tests/ignite/engine/test_create_supervised.py

guptaaryan16 · 2023-02-15T17:09:08Z

Hey @vfdev-5 can you give me an idea on how to update the API doc

tests/ignite/engine/test_create_supervised.py

vfdev-5 · 2023-02-17T11:44:13Z

@guptaaryan16 I pushed this PR : guptaaryan16#1 to your master branch on how to update the tests. Could you please merge this PR quickly to unblock this PR as we are planning the release. Thanks

Updated tests

guptaaryan16 · 2023-02-17T13:27:54Z

Okay I am working in this issue and hope to complete this today. Thanks for helping with the tests should I update the docs of the API

tests/ignite/engine/test_create_supervised.py

vfdev-5 · 2023-02-17T13:35:16Z

Okay I am working in this issue and hope to complete this today. Thanks for helping with the tests should I update the docs of the API

Thanks @guptaaryan16 ! Can you add versionchanged into the docstrings and also usage example can be helpful

ignite/ignite/engine/__init__.py

Lines 90 to 91 in d820c82

    
               .. versionchanged:: 0.4.7 
        
                   Added Gradient Accumulation.

    .. versionchanged:: 0.4.7
        Added `model_transform` to transform model's output

guptaaryan16 · 2023-02-17T13:39:34Z

@vfdev-5 I don't know why but to make the tests work I had to remove the bias variable in the tests as it gives a NoneType error

vfdev-5 · 2023-02-17T13:44:12Z

@vfdev-5 I don't know why but to make the tests work I had to remove the bias variable in the tests as it gives a NoneType error

I checked the tests locally and they were passing. Let's revert this change and see the exact error message

ignite/engine/__init__.py

vfdev-5 · 2023-02-17T14:28:23Z

OK, I see, we have to remove all related lines:

model.fc.bias.data.zero_()

assert model.fc.bias.item() == approx(0.0)

vfdev-5

Thanks @guptaaryan16

guptaaryan16 and others added 2 commits February 4, 2023 16:58

Add model_transform in create supervised trainer

bd084cc

autopep8 fix

35b5f72

github-actions bot added the module: engine Engine module label Feb 4, 2023

guptaaryan16 added 2 commits February 4, 2023 17:15

Made changes in the model_transform

6e2116d

Merge branch 'master' of github.com:guptaaryan16/ignite

febd297

guptaaryan16 changed the title ~~Add model_transform in create supervised trainer~~ Add model_transform in create supervised trainer[WIP] Feb 4, 2023

autopep8 fix

1597942

vfdev-5 reviewed Feb 4, 2023

View reviewed changes

ignite/engine/__init__.py Outdated Show resolved Hide resolved

ignite/engine/__init__.py Outdated Show resolved Hide resolved

ignite/engine/__init__.py Outdated Show resolved Hide resolved

guptaaryan16 and others added 4 commits February 7, 2023 22:43

Add test for Supervised trainer output transform

c330ca9

autopep8 fix

ddf7741

changed code formatting

0cfef6a

Merge branch 'master' of https://github.com/guptaaryan16/ignite

53c770f

vfdev-5 reviewed Feb 8, 2023

View reviewed changes

tests/ignite/engine/test_create_supervised.py Outdated Show resolved Hide resolved

vfdev-5 reviewed Feb 8, 2023

View reviewed changes

ignite/engine/__init__.py Outdated Show resolved Hide resolved

guptaaryan16 and others added 10 commits February 14, 2023 19:24

Add necessary changes to tests for model transform

91414a3

autopep8 fix

b18a4fa

Some code formatting changes

6e920bc

Merged conflict changes

5fab439

autopep8 fix

408e456

Made code formatting changes

c6b674d

Merge changes

eeb24e4

autopep8 fix

7fb561d

Code formatting changes

02b9549

Merge branch 'master' of https://github.com/guptaaryan16/ignite

ac22c38

vfdev-5 changed the title ~~Add model_transform in create supervised trainer[WIP]~~ Add model_transform in create supervised trainer Feb 14, 2023

vfdev-5 reviewed Feb 14, 2023

View reviewed changes

tests/ignite/engine/test_create_supervised.py Outdated Show resolved Hide resolved

guptaaryan16 added 2 commits February 15, 2023 21:33

Changed somethng in the test

64abf7f

Merge branch 'master' of https://github.com/guptaaryan16/ignite

4e66c46

vfdev-5 reviewed Feb 15, 2023

View reviewed changes

tests/ignite/engine/test_create_supervised.py Outdated Show resolved Hide resolved

Updated tests

35b1bc7

vfdev-5 and others added 2 commits February 17, 2023 13:17

Merge branch 'master' into model-transform

b549d18

Merge pull request #1 from vfdev-5/model-transform

5413c90

Updated tests

vfdev-5 reviewed Feb 17, 2023

View reviewed changes

tests/ignite/engine/test_create_supervised.py Outdated Show resolved Hide resolved

Update tests/ignite/engine/test_create_supervised.py

d820c82

guptaaryan16 and others added 3 commits February 17, 2023 19:07

Made some changes in the tests

a7369ab

Merge branch 'master' of https://github.com/guptaaryan16/ignite

5f456b6

autopep8 fix

19efa2f

guptaaryan16 added 3 commits February 17, 2023 19:14

Some change

de1e7f1

Merge branch 'master' of https://github.com/guptaaryan16/ignite

b68559f

Revert tests and add docstrings

b6ff95c

vfdev-5 reviewed Feb 17, 2023

View reviewed changes

guptaaryan16 added 3 commits February 17, 2023 20:22

Changed the test version

f8372d4

Some necessary changes

c555f2c

Merge changes

f553b13

vfdev-5 approved these changes Feb 17, 2023

View reviewed changes

Merge branch 'master' into master

62f9e80

vfdev-5 enabled auto-merge (squash) February 17, 2023 16:17

vfdev-5 merged commit c7c0df0 into pytorch:master Feb 17, 2023

david-waterworth mentioned this pull request Mar 16, 2023

model_transform has been added to create_supervised_trainer and create_supervised_evaluator but its not used by create_supervised_evaluator #2894

Closed

Uh oh!

Conversation

guptaaryan16 commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vfdev-5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 commented Feb 4, 2023

Uh oh!

Uh oh!

vfdev-5 commented Feb 8, 2023

Uh oh!

Uh oh!

vfdev-5 commented Feb 14, 2023

Uh oh!

guptaaryan16 commented Feb 14, 2023

Uh oh!

Uh oh!

guptaaryan16 commented Feb 15, 2023

Uh oh!

Uh oh!

vfdev-5 commented Feb 17, 2023

Uh oh!

guptaaryan16 commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vfdev-5 commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guptaaryan16 commented Feb 17, 2023

Uh oh!

vfdev-5 commented Feb 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 commented Feb 17, 2023

Uh oh!

vfdev-5 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guptaaryan16 commented Feb 4, 2023 •

edited

Loading

guptaaryan16 commented Feb 17, 2023 •

edited

Loading

vfdev-5 commented Feb 17, 2023 •

edited

Loading