Skip to content

Drop python 3.7 from CI#2836

Merged
vfdev-5 merged 6 commits intopytorch:masterfrom
abhi-glitchhg:droppython3.7
Feb 2, 2023
Merged

Drop python 3.7 from CI#2836
vfdev-5 merged 6 commits intopytorch:masterfrom
abhi-glitchhg:droppython3.7

Conversation

@abhi-glitchhg
Copy link
Copy Markdown
Contributor

Fixes #2834

I used grep command to look for 3.7 in workflow files; and also removed the target version py37 from pyproject.toml file.

Opening as a draft to check CI is happy with current state.

@github-actions github-actions bot added the ci CI label Jan 30, 2023
@abhi-glitchhg abhi-glitchhg changed the title Droppython3.7 Drop python 3.7 from CI Jan 30, 2023
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Jan 30, 2023

@abhi-glitchhg thanks for the PR, seems like torch XLA is still on python 3.7

@abhi-glitchhg
Copy link
Copy Markdown
Contributor Author

@abhi-glitchhg thanks for the PR, seems like torch XLA is still on python 3.7

yeah; what should we do; Should i make an issue for this on XLA repo?

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Jan 30, 2023

@abhi-glitchhg
Copy link
Copy Markdown
Contributor Author

Hmm,

I went through the error

WARNING: Skipping torch as it is not installed.
WARNING: Skipping torchvision as it is not installed.
CommandException: No URLs matched: gs://tpu-pytorch/wheels/colab/torch-nightly-cp38-cp38m-linux_x86_64.whl
CommandException: No URLs matched: gs://tpu-pytorch/wheels/colab/torch_xla-nightly-cp38-cp38m-linux_x86_64.whl
CommandException: No URLs matched: gs://tpu-pytorch/wheels/colab/torchvision-nightly-cp38-cp38m-linux_x86_64.whl
WARNING: Requirement 'torch-nightly-cp38-cp38m-linux_x86_64.whl' looks like a filename, but the file does not exist
ERROR: torch-nightly-cp38-cp38m-linux_x86_64.whl is not a supported wheel on this platform.

We are running this set up script to download the wheels. From the error we can see that 3.8 python version is being used by the script but URL is not matching(found?).

@vfdev-5, could it be possible that nightly versions for 3.8 are not up there? or can we get the list of all the available xla wheels for 3.8 version?

Thanks

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Jan 30, 2023

@abhi-glitchhg I do not know but I just tried in colab without any accelerators to run the following:

pip install cloud-tpu-client==0.10 --pre torch https://storage.googleapis.com/tpu-pytorch/wheels/colab/torch_xla-nightly-cp38-cp38-linux_x86_64.whl

and it seems to work...

You can try either on your fork to enable GH actions and figure out how to install torch xla or either you can do things in docker container...

lets see if ci is is okay with this
@vfdev-5 vfdev-5 marked this pull request as ready for review February 2, 2023 12:36
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @abhi-glitchhg
LGTM

[tool.black]
line-length = 120
target-version = ['py37', 'py38', 'py39']
target-version = ['py38', 'py39']
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should add 3.10 as target version in here as well.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also thinking about that. But let's keep it like this

@vfdev-5 vfdev-5 merged commit b76b825 into pytorch:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Drop support for python 3.7

2 participants