Conversation
|
@abhi-glitchhg thanks for the PR, seems like torch XLA is still on python 3.7 |
yeah; what should we do; Should i make an issue for this on XLA repo? |
|
It may be possible that we are not correctly installing it for python 3.8. In colab they seem to pick python 3.8 : https://colab.research.google.com/github/pytorch/xla/blob/master/contrib/colab/pytorch-xla-profiling-colab.ipynb |
|
Hmm, I went through the error We are running this set up script to download the wheels. From the error we can see that 3.8 python version is being used by the script but URL is not matching(found?). @vfdev-5, could it be possible that nightly versions for 3.8 are not up there? or can we get the list of all the available xla wheels for 3.8 version? Thanks |
|
@abhi-glitchhg I do not know but I just tried in colab without any accelerators to run the following: and it seems to work... You can try either on your fork to enable GH actions and figure out how to install torch xla or either you can do things in docker container... |
lets see if ci is is okay with this
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR, @abhi-glitchhg
LGTM
| [tool.black] | ||
| line-length = 120 | ||
| target-version = ['py37', 'py38', 'py39'] | ||
| target-version = ['py38', 'py39'] |
There was a problem hiding this comment.
i think we should add 3.10 as target version in here as well.
There was a problem hiding this comment.
I was also thinking about that. But let's keep it like this
Fixes #2834
I used
grepcommand to look for 3.7 in workflow files; and also removed the target versionpy37frompyproject.tomlfile.Opening as a draft to check CI is happy with current state.