Merged
Conversation
github-actions
bot
added
module: contrib
Collaborator
Author
|
@vfdev-5 , in |
Collaborator
|
Events type is a bit tricky and we need unify the typehints at some point. As a rule of thumb, we have
Let's first fix mypy issues and in a follow-up PR we can tackle typehint for events. |
And add a tiny test for wandb_logger
vfdev-5
approved these changes
Nov 16, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @sadra-barikbin !
Collaborator
|
As failing tests are unrelated, merging this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Using new MyPy release(0.991) raises some errors. This PR attempts to resolve them.