Put ModuleNotFoundError instead of RuntimeError in proper places#2750
Merged
vfdev-5 merged 8 commits intopytorch:masterfrom Oct 23, 2022
Merged
Conversation
github-actions
bot
added
examples
sadra-barikbin
force-pushed
the
Fix-module-not-found-instead-of-runtime-error-2743
branch
from
97c80e3 to
d67d3d4
Compare
vfdev-5
reviewed
Oct 23, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @sadra-barikbin
Let's just revert changes in jupyter notebooks. Currently there is a lot unrelated changes, so I think we can just update python code.
Collaborator
|
@sadra-barikbin ipynb are still in the PR |
vfdev-5
approved these changes
Oct 23, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks @sadra-barikbin !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2743