Dropper TrainsLoger and TrainsSaver also removed the backward compati…#2742
Dropper TrainsLoger and TrainsSaver also removed the backward compati…#2742vfdev-5 merged 6 commits intopytorch:masterfrom soma2000-lang:master
Conversation
|
@soma2000-lang can you please update |
|
@louis-she could you please review as you wanted to do that initially :) |
|
@vfdev-5 of course |
|
@vfdev-5 sure |
| "This contrib module requires clearml to be installed. " | ||
| "You may install clearml using: \n pip install clearml \n" | ||
| ) | ||
| raise RuntimeError( |
There was a problem hiding this comment.
I think we can use ModuleNotFoundError to replace RuntimeError here.
There was a problem hiding this comment.
Yes, it makes sense, thanks for the suggestion! Then it would be better to consistently raise that in all contrib handlers and classes where we check for available 3rd party library. @louis-she can you please open a new issue, I'll label it as good first issue/hacktoberfest
|
Other things look good to me. |
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
lgtm, thanks @soma2000-lang !
Thanks for the review @louis-she
3 participants
In this pr I have dropped the TrainsLogger and TrainsSaver file and also removed the backward compatibility.
Fixes #2740