Skip to content

fix visdom tests#2739

Merged
vfdev-5 merged 2 commits intopytorch:masterfrom
louis-she:louis/fix-visdom-tests
Oct 9, 2022
Merged

fix visdom tests#2739
vfdev-5 merged 2 commits intopytorch:masterfrom
louis-she:louis/fix-visdom-tests

Conversation

@louis-she
Copy link
Copy Markdown
Contributor

@louis-she louis-she commented Oct 9, 2022

Fixes #2738

The error is that visdom failed to start the server since it can not find $HOME/.visdom directory. This directory may have been automatically created in the previous version of visdom. I have had a test that in a brand-new virtual env, install visdom and try to start server by python -m visdom.server, it also failed for the same reason.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louis-she, nice! Thanks a lot for the quick fix and investigations!

@vfdev-5 vfdev-5 merged commit 19f8ad2 into pytorch:master Oct 9, 2022
@louis-she louis-she deleted the louis/fix-visdom-tests branch October 10, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update visdom handler

2 participants