Add get_param method to ParamGroupScheduler#2720
Merged
vfdev-5 merged 6 commits intopytorch:masterfrom Sep 27, 2022
Merged
Conversation
vfdev-5
reviewed
Sep 27, 2022
vfdev-5
approved these changes
Sep 27, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR @sadra-barikbin
looks good to me.
Left a small comment on updating docstring
Collaborator
|
I close and reopen the PR to restart the CI |
Collaborator
Author
|
@vfdev-5 , |
Collaborator
|
@sadra-barikbin it is from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #2704 , in order to be able to have multiple groups in
FastaiLRFinderwhenstep_mode != 'exp', I suggested this code:https://github.com/pytorch/ignite/pull/2704/files#r975195661
which uses
ParamGroupScheduler.FastaiLRFindercallsget_paramon its scheduler inignite/ignite/handlers/lr_finder.py
Line 160 in daa3c96
but
ParamGroupSchedulerhas not this method. This PR adds that method.