Skip to content

Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank#2664

Merged
vfdev-5 merged 2 commits intopytorch:masterfrom
puhuk:manhattan_maximum_ae_geometric_mae
Aug 23, 2022
Merged

Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank#2664
vfdev-5 merged 2 commits intopytorch:masterfrom
puhuk:manhattan_maximum_ae_geometric_mae

Conversation

@puhuk
Copy link
Copy Markdown
Contributor

@puhuk puhuk commented Aug 22, 2022

Description: Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error to generate with different rank

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

…, `maximum_absolute_error`

Update `geometric_mean_relative_absolute_error`, `manhattan_distance`, `maximum_absolute_error` to generate with different rank
@puhuk puhuk changed the title Update 3 metrics in test for generating data with different rank Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank Aug 23, 2022
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk , lgtm !

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 23, 2022 06:42
@vfdev-5 vfdev-5 merged commit 0818fe3 into pytorch:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants