Update to resolve CI warnings#2651
Conversation
To resolve issue pytorch#2649 Will send soon to fix warnings in `test_precision.py`
|
For warnings from |
Can you point to the code what you are talking about ? |
For this line, because it generates data with zeros, ignite/tests/ignite/metrics/test_precision.py Line 154 in c506c31 it occurs error with being set to zero in ignite/tests/ignite/metrics/test_precision.py Line 130 in c506c31 When I add |
|
No, I didn't because document says the default value is |
|
@puhuk please fix code formatting with https://github.com/pytorch/ignite/blob/master/CONTRIBUTING.md#formatting-code |
|
@puhuk actually, there are still warnings:
Please fix them as well |
|
Still some warings in https://github.com/pytorch/ignite/runs/7963618423?check_suite_focus=true#step:15:1826 |
No, these warnings are in installed packages, we can't do anything with them. |
| super(InceptionModel, self).__init__() | ||
| self._device = device | ||
| self.model = models.inception_v3(pretrained=True).to(self._device) | ||
| if Version(torch.__version__) <= Version("1.7.0"): |
There was a problem hiding this comment.
This version check is incorrect
There was a problem hiding this comment.
You have to check for torchvision version here
Fixes #2649
Description:
Update to resolve CI warnings
Will send soon to fix warnings in
test_precision.pyCheck list: