Improving various tests with parametrize#2552
Merged
vfdev-5 merged 14 commits intopytorch:masterfrom Apr 19, 2022
Merged
Conversation
added 11 commits
April 8, 2022 15:14
…se.py using pytest parametrize
Collaborator
|
@nmcguire101 thanks for the PR. By the way, for effectively contributing using git, please check https://github.com/firstcontributions/first-contributions |
vfdev-5
reviewed
Apr 17, 2022
vfdev-5
reviewed
Apr 18, 2022
Collaborator
There was a problem hiding this comment.
@nmcguire101 can you please also update test_multiclass_input
nmcguire101
force-pushed
the
nmcguire101
branch
from
5f49951 to
281a047
Compare
vfdev-5
reviewed
Apr 18, 2022
vfdev-5
approved these changes
Apr 19, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks @nmcguire101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2522 Adding more improvements to tests
Description:
Improved test tests\ignite\contrib\metrics\test_accuracy.py using pytest parametrize
Check list: