Feature add whitelist parameter issue 2548 by sadra-barikbin · Pull Request #2550 · pytorch/ignite

sadra-barikbin · 2022-04-14T22:49:52Z

Fixes #2548

Description:
I made some refactors first and then added whitelist parameter to specified classes in the issue.

Check list:

New tests are added (if a new feature is added)
New doc strings: description and/or example code are in RST format
Documentation is updated (if required)

Closes pytorch#2438

Closes pytorch#1754

Also fix bug in min_lr check

sadra-barikbin · 2022-04-17T21:50:06Z

ClearML *ScalarHandler seemingly works as expected but histogram ones not. Plots tab in project page is empty.

sadra-barikbin · 2022-04-17T21:51:37Z

TensorboardLogger works properly.

Closes pytorch#2459 with help of PR pytorch#2470

ignite/engine/__init__.py

tests/ignite/contrib/handlers/test_clearml_logger.py

vfdev-5 · 2022-05-01T16:15:26Z

@sadra-barikbin can you please resolve the conflict and update this PR

tests/ignite/engine/test_create_supervised.py

ignite/contrib/handlers/tensorboard_logger.py

ignite/contrib/handlers/base_logger.py

ignite/contrib/handlers/clearml_logger.py

ignite/contrib/handlers/base_logger.py

vfdev-5

@sadra-barikbin Thanks, lgtm

vfdev-5 · 2022-05-02T22:45:23Z

ClearML *ScalarHandler seemingly works as expected but histogram ones not. Plots tab in project page is empty.

@sadra-barikbin you were reporting that previously. Can you check again if this is still a problem with the latest clearml and see if it is related to our code or not. cc @bmartinn

sadra-barikbin · 2022-05-03T01:53:29Z

ClearML histograms were still missing. There was an issue in calling WeightsGradientHistHelper on logger construction. This object is used in logging histograms. Its report_freq parameter's default value is 100 so among every 100 calls 99 of them are returned without any actual log. I changed it to 1 and histograms are now plotted correctly.

Bug place
Final result:

The Iteration 0 that is in plot title is due to internal stuff of WeightsGradientHistHelper. As we call add_histogram, it does some processes and finally calls clearml logger's add_surface method with our arguments title and series unchanged and also with another argument, iteration hard-coded to zero.

vfdev-5 · 2022-05-03T08:14:29Z

@sadra-barikbin thanks a lot for investigations ! It is very helpful !

As we call add_histogram, it does some processes and finally calls clearml logger's add_surface method with our arguments title and series unchanged and also with another argument, iteration hard-coded to zero.

So, we call add_histogram:

ignite/ignite/contrib/handlers/clearml_logger.py

Lines 493 to 498 in a74b5b0

    
           logger.grad_helper.add_histogram( 
        
               title=f"{tag_prefix}weights_{title_name}", 
        
               series=series_name, 
        
               step=global_step, 
        
               hist_data=p.grad.detach().cpu().numpy(), 
        
           )

and define step as global_step but step is not propagated to add_surface ? -> Apparently, it is a bit complicated code in clearml to track what happens with step. Anyway, I asked on their issue tracker and let's see.

I think we can merge in this state and improve later if needed. Thanks again @sadra-barikbin

sadra-barikbin and others added 30 commits January 22, 2022 23:03

Remove unnecessary code in BaseOutputHandler

3484a59

Closes pytorch#2438

Merge branch 'pytorch:master' into master

2c8eed9

Add ReduceLROnPlateauScheduler

ccf2364

Closes pytorch#1754

Fix indentation issue

7f7dae6

Fix another indentation issue

896e482

Fix PEP8 related issues

cbc8d04

Fix other PEP8 related issues

47b0622

Fix hopefully the last PEP8 related issue

91d058e

Fix hopefully the last PEP8 related issue

9fd7d61

Merge branch 'pytorch:master' into master

b7dc921

Merge branch 'master' of https://github.com/sadra-barikbin/ignite

e0644e3

Remove ReduceLROnPlateau's specific params and add link to it

c95a2be

Also fix bug in min_lr check

Fix state_dict bug and add a test

96554d0

Merge branch 'pytorch:master' into master

145dabc

Update docs

0aee28a

Merge branch 'master' into master

307803c

Merge branch 'pytorch:master' into master

0129572

Merge branch 'master' of https://github.com/pytorch/ignite

a17a5b2

Add doctest and fix typo

b3ea962

Merge branch 'master' of https://github.com/pytorch/ignite

e2e6831

Merge branch 'master' of https://github.com/pytorch/ignite

b88c9e1

Merge branch 'master' of https://github.com/sadra-barikbin/ignite

8d0ae3c

Merge branch 'master' into master

408b271

Merge branch 'master' of https://github.com/pytorch/ignite

102ba25

Merge branch 'master' of https://github.com/pytorch/ignite

a5d9bab

Merge branch 'master' of https://github.com/pytorch/ignite

8ad4113

Merge branch 'master' of https://github.com/pytorch/ignite

f4ba590

Merge branch 'master' of https://github.com/pytorch/ignite

c594fd7

Merge branch 'master' of https://github.com/pytorch/ignite

52dbb5c

Merge branch 'master' of https://github.com/pytorch/ignite

93ce080

sadra-barikbin force-pushed the Feature-add-whitelist-parameter-issue-2548 branch from 74ba501 to b1fd3b0 Compare April 17, 2022 21:39

Fix zero_grad place in trainer step

fef3f67

Closes pytorch#2459 with help of PR pytorch#2470

sadra-barikbin force-pushed the Feature-add-whitelist-parameter-issue-2548 branch from db97792 to fef3f67 Compare April 17, 2022 22:30

sadra-barikbin and others added 2 commits April 18, 2022 03:00

Merge branch 'master' into Feature-add-whitelist-parameter-issue-2548

e7794d6

autopep8 fix

6f6243b

vfdev-5 reviewed Apr 18, 2022

View reviewed changes

ignite/engine/__init__.py Show resolved Hide resolved

vfdev-5 reviewed Apr 18, 2022

View reviewed changes

tests/ignite/contrib/handlers/test_clearml_logger.py Show resolved Hide resolved

vfdev-5 reviewed Apr 18, 2022

View reviewed changes

tests/ignite/contrib/handlers/test_clearml_logger.py Show resolved Hide resolved

sadra-barikbin added 2 commits May 2, 2022 15:53

Merge branch 'master' into Feature-add-whitelist-parameter-issue-2548

3243a10

Merge branch 'master' into Feature-add-whitelist-parameter-issue-2548

7530215

vfdev-5 reviewed May 2, 2022

View reviewed changes

tests/ignite/engine/test_create_supervised.py Outdated Show resolved Hide resolved

vfdev-5 reviewed May 2, 2022

View reviewed changes

ignite/contrib/handlers/tensorboard_logger.py Outdated Show resolved Hide resolved

Fix bugs

6d96c6c

vfdev-5 reviewed May 2, 2022

View reviewed changes

ignite/contrib/handlers/base_logger.py Outdated Show resolved Hide resolved

ignite/contrib/handlers/clearml_logger.py Outdated Show resolved Hide resolved

sadra-barikbin added 4 commits May 3, 2022 02:15

Fix bugs in loggers

e45fc36

Fix bug in test_create_supervised

9b77886

Change reduction type hint in base_logger

2c02406

Fix mypy error

96238a7

vfdev-5 reviewed May 2, 2022

View reviewed changes

ignite/contrib/handlers/base_logger.py Show resolved Hide resolved

vfdev-5 mentioned this pull request May 2, 2022

fixing issue #2328 from PyData's sprint #2421

Closed

vfdev-5 approved these changes May 2, 2022

View reviewed changes

Fix bug causing missing clearml histograms

7917775

vfdev-5 mentioned this pull request May 3, 2022

add_histogram method calls report_surface with hard-coded iteration=0 clearml/clearml#666

Open

vfdev-5 merged commit 4f6b8b1 into pytorch:master May 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature add whitelist parameter issue 2548#2550

Feature add whitelist parameter issue 2548#2550
vfdev-5 merged 47 commits intopytorch:masterfrom
sadra-barikbin:Feature-add-whitelist-parameter-issue-2548

sadra-barikbin commented Apr 14, 2022

Uh oh!

sadra-barikbin commented Apr 17, 2022

Uh oh!

sadra-barikbin commented Apr 17, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 commented May 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 left a comment

Uh oh!

vfdev-5 commented May 2, 2022 •

edited

Loading

Uh oh!

sadra-barikbin commented May 3, 2022

Uh oh!

vfdev-5 commented May 3, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sadra-barikbin commented Apr 14, 2022

Uh oh!

sadra-barikbin commented Apr 17, 2022

Uh oh!

sadra-barikbin commented Apr 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 commented May 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vfdev-5 left a comment

Choose a reason for hiding this comment

Uh oh!

vfdev-5 commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadra-barikbin commented May 3, 2022

Uh oh!

vfdev-5 commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sadra-barikbin commented Apr 17, 2022 •

edited

Loading

vfdev-5 commented May 2, 2022 •

edited

Loading

vfdev-5 commented May 3, 2022 •

edited

Loading