updated test_param_scheduler replacing multiple calls with pytest.parametrize#2531
Merged
vfdev-5 merged 3 commits intopytorch:masterfrom Mar 29, 2022
Merged
Conversation
vfdev-5
reviewed
Mar 27, 2022
Collaborator
|
@Ishan-Kumar2 thanks for the PR, I left a comment to address.
I agree, let's keep them as they are now... |
vfdev-5
approved these changes
Mar 29, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
@Ishan-Kumar2 LGTM, thanks for the PR !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2522
Description:
Updated handlers/test_param_scheduler replacing multiple calls with pytest.parametrize
Haven't converted
ignite/tests/ignite/handlers/test_param_scheduler.py
Line 812 in 69ea3c8
and
ignite/tests/ignite/handlers/test_param_scheduler.py
Line 1228 in 69ea3c8
because it has conditional calls. We could have different fixtures for all the cases but I believe that would make the code less readable, let me know what you think would be best for these tests.
Check list: