Merged
Conversation
Update docstring of MSE so that it's consistent with the actual behavior.
Collaborator
|
@leotac thanks for the update! We'll check docs rendering once GHA will be working again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docstring of MSE so that it's consistent with the actual behavior.
Description:
MSE is actually computing the sum of squared differences for each element i before taking the average. The current documentation only covers the case where y is a vector (predicting scalar values), but in cases where the prediction has higher dimension than 1 the formula is not valid/clear.
With the change, it would be valid for both cases.
Check list: