@divo12 thanks for PR, please check https://github.com/pytorch/ignite/blob/master/CONTRIBUTING.md#formatting-code to reformat the code and remove all unnecessary files like notebook checkpoints etc, all new added files.

@vfdev-5 done the required changes for the PR

@divo12 thanks, I started the CI to see the results. Can you also please rename PR's title and put into the description:

- Fixes #{2522}
+ Related to #2522

as this PR shouldn't close the issue.

@vfdev-5 done all the required changes

@sdesrozis @vfdev-5 I got a failed check on one of the tests...can you please review it

@divo12 I restarted failed test, looks like CI flakiness.

missing test_model_checkpoint_simple_recovery_from_existing_non_empty should be refactored using pytest.mark.parametrize.

@divo12 please address the open comments by @sdesrozis

@sdesrozis I have resolved the other issuses..can you help me with the last one-
#2525 (comment)?

Look the mentioned test. You didn’t refactor it, right ?

Because i am not getting how to refactor that like my dirname is fixed and the other two are varying
@vfdev-5 help with this issue

Because i am not getting how to refactor that like my dirname is fixed and the other two are varying

@vfdev-5 help with this issue

Sorry I didn't catch whether there is still an issue.

Because i am not getting how to refactor that like my dirname is fixed and the other two are varying @vfdev-5 help with this issue

@divo12 To make test_model_checkpoint_simple_recovery_from_existing_non_empty parametrized you can just add the decorator and keep dirname fixture:

@pytest.mark.parametrize("ext", [".txt", ".pt"])
def test_model_checkpoint_simple_recovery_from_existing_non_empty(ext, dirname):
    pass

@vfdev-5 done the changes