Skip to content

Fix distutils deprecation warning#2476

Merged
vfdev-5 merged 7 commits intopytorch:masterfrom
DevPranjal:fix-depr-warn
Feb 20, 2022
Merged

Fix distutils deprecation warning#2476
vfdev-5 merged 7 commits intopytorch:masterfrom
DevPranjal:fix-depr-warn

Conversation

@DevPranjal
Copy link
Copy Markdown
Contributor

@DevPranjal DevPranjal commented Feb 18, 2022

Fixes #2472

Description: Fix distutils deprecation warning by using Version from packaging.versioning in place of LooseVersion

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added module: distributed Distributed module module: metrics Metrics module labels Feb 18, 2022
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 18, 2022

@DevPranjal thanks for the PR, looks good. Do you think the failure is related to the change ?

@DevPranjal
Copy link
Copy Markdown
Contributor Author

DevPranjal commented Feb 18, 2022 •
edited
Loading

I didn't find the failures related, I might be wrong. They were not occuring recently :(.

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 18, 2022 •
edited
Loading

@DevPranjal they are unrelated, provided a temporary CI fix: #2477
Once it is merged please sync your PR with master and we can land it. EDIT: will do it here with GitHub.

vfdev-5
vfdev-5 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DevPranjal

@vfdev-5 vfdev-5 enabled auto-merge (squash) February 18, 2022 17:36
@DevPranjal
Copy link
Copy Markdown
Contributor Author

DevPranjal commented Feb 19, 2022

Tests related to pytorch-nightly are passing since AttributeError: module 'distutils' has no attribute 'version' has been fixed recently.
This also seems related to this PR, since distutils is involved. Will look into it.

@vfdev-5 vfdev-5 disabled auto-merge February 19, 2022 16:50
@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 19, 2022

@DevPranjal let's temporarily fix distutils to an older version such that stable pytorch will pass as well ?

@vfdev-5
Copy link
Copy Markdown
Collaborator

vfdev-5 commented Feb 19, 2022

@DevPranjal can you also please replace this:

@DevPranjal
Copy link
Copy Markdown
Contributor Author

DevPranjal commented Feb 20, 2022

@vfdev-5 all checks passing now :)

@vfdev-5 vfdev-5 enabled auto-merge (squash) February 20, 2022 09:31
@vfdev-5 vfdev-5 disabled auto-merge February 20, 2022 10:07
@vfdev-5 vfdev-5 enabled auto-merge (squash) February 20, 2022 10:08
@vfdev-5 vfdev-5 merged commit 202df21 into pytorch:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: distributed Distributed module module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix DeprecationWarning: distutils Version classes are deprecated

2 participants

@DevPranjal @vfdev-5