Add ReduceLROnPlateauScheduler feature#2449
Merged
vfdev-5 merged 23 commits intopytorch:masterfrom Feb 20, 2022
Merged
Conversation
github-actions
bot
added
module: contrib
Collaborator
|
@sadra-barikbin thanks for the PR, can you run the following to fix code format:
|
vfdev-5
reviewed
Feb 3, 2022
sadra-barikbin
force-pushed
the
master
branch
from
5a4bfd1 to
06890ba
Compare
vfdev-5
reviewed
Feb 3, 2022
sadra-barikbin
force-pushed
the
master
branch
from
06890ba to
e0644e3
Compare
vfdev-5
reviewed
Feb 3, 2022
vfdev-5
reviewed
Feb 3, 2022
vfdev-5
reviewed
Feb 3, 2022
Also fix bug in min_lr check
sadra-barikbin
force-pushed
the
master
branch
from
2b753f7 to
c95a2be
Compare
sadra-barikbin
force-pushed
the
master
branch
from
2fd38f9 to
96554d0
Compare
Collaborator
Author
|
Hi, @vfdev-5 Anything else should I do? |
vfdev-5
reviewed
Feb 9, 2022
Collaborator
|
Hi @sadra-barikbin thanks for updates, I left few other comments. I checked how it works and now i understand that you are patching an original private method : |
sadra-barikbin
force-pushed
the
master
branch
3 times, most recently
from
f159a56 to
cdadf6c
Compare
sadra-barikbin
force-pushed
the
master
branch
from
cdadf6c to
0aee28a
Compare
vfdev-5
reviewed
Feb 14, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
@sadra-barikbin thanks for the updates and sorry for delay !
Few nits about verbose and we can merge this PR.
sdesrozis
reviewed
Feb 14, 2022
sdesrozis
reviewed
Feb 14, 2022
sdesrozis
reviewed
Feb 14, 2022
Collaborator
|
@sadra-barikbin can you resolve conflicts with master and address remaining comments. We can try to merge it then. Thanks a lot ! |
sadra-barikbin
force-pushed
the
master
branch
from
8df9500 to
e2e6831
Compare
vfdev-5
approved these changes
Feb 20, 2022
Collaborator
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the update @sadra-barikbin !
Good to the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1754
Description:
Add ReduceLROnPlateauScheduler which basically is a wrapper around
torch.optim.lr_scheduler.ReduceLROnPlateau. It supportsparam_group_indexandsave_historyparams.Check list: