Fix for issues related to mypy#2435
Fix for issues related to mypy#2435vfdev-5 merged 6 commits intopytorch:masterfrom sayantan1410:master
Conversation
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the PR @sayantan1410
I left a question
|
@vfdev-5 I have tried to look at each of the error codes in the lines where the errors where generating, Let me know if I have made some mistake. |
vfdev-5
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update @sayantan1410 !
Let's see if mypy is passing and we can merge it.
|
@sayantan1410 can you fix flake8 error: |
|
@vfdev-5 Sorry, probably there were two white spaces and I removed one and that's why it failed again, actually the extra white space did not show in my code editor. |
|
@sayantan1410 if you are using VSCode, you can trim extra white spaces with this option: |
|
@vfdev-5 Thank you so much for merging the PR. |
|
@sayantan1410 failing test is codecov patch, this one is not always reliable indicator and we ignore it sometimes |
|
@vfdev-5 Okay, thank you, also yes I was using VS Code and I changed the settings for trimming white spaces to true. |
Fixes #2361
Check list:
Let me know if there is any mistake @vfdev-5