Add doctest for StepStateScheduler#2394
Merged
sdesrozis merged 20 commits intopytorch:masterfrom Dec 29, 2021
bibhabasumohapatra:doc-StepStateScheduler
Merged
Add doctest for StepStateScheduler#2394sdesrozis merged 20 commits intopytorch:masterfrom bibhabasumohapatra:doc-StepStateScheduler
sdesrozis merged 20 commits intopytorch:masterfrom
bibhabasumohapatra:doc-StepStateScheduler
Conversation
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
Contributor
|
@bibhabasumohapatra Thanks ! I left a few minor comments to address. The point is to be consistent witth the previous PR. |
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Co-authored-by: Sylvain Desroziers <[email protected]>
Contributor
Author
wanted to point out epoch ... for clarity, but yes Consistency is valid point. |
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
reviewed
Dec 29, 2021
Co-authored-by: Sylvain Desroziers <[email protected]>
sdesrozis
suggested changes
Dec 29, 2021
Contributor
sdesrozis
left a comment
sdesrozis
left a comment
There was a problem hiding this comment.
Please, address the comment #2394 (comment)
sdesrozis
reviewed
Dec 29, 2021
sdesrozis
approved these changes
Dec 29, 2021
Contributor
sdesrozis
left a comment
sdesrozis
left a comment
There was a problem hiding this comment.
@bibhabasumohapatra Thanks, LGTM !
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2266
Description:
added doctest for StepStateScheduler
Check list: