Merged
Conversation
trying to update loss.py doctest
sdesrozis
reviewed
Nov 25, 2021
sdesrozis
reviewed
Nov 25, 2021
Contributor
|
@Eunjnnn Thank you very much for your help ! I left some comments, tell me if you need help. |
Contributor
|
@Eunjnnn Are you still working on this ? It would be great to merge soon. |
sdesrozis
reviewed
Dec 5, 2021
sdesrozis
reviewed
Dec 5, 2021
sdesrozis
reviewed
Dec 5, 2021
sdesrozis
reviewed
Dec 5, 2021
Contributor
|
@Eunjnnn Thanks for the update. It’s almost done, please do the fix I suggested. Thanks again ! |
sdesrozis
reviewed
Dec 6, 2021
ignite/metrics/loss.py
Outdated
| .. testcode:: | ||
|
|
||
| model = default_model | ||
| criterion = nll_loss |
Contributor
There was a problem hiding this comment.
Suggested change
| criterion = nll_loss | |
| criterion = nn.NLLLoss() |
sdesrozis
reviewed
Dec 6, 2021
docs/source/conf.py
Outdated
|
|
||
| import torch | ||
| from torch import nn, optim | ||
| from torch.nn.functional import nll_loss |
Contributor
There was a problem hiding this comment.
Suggested change
| from torch.nn.functional import nll_loss |
See below, no need to introduce this import.
51 tasks
Ishan-Kumar2
pushed a commit
to Ishan-Kumar2/ignite
that referenced
this pull request
Dec 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2265
Description: add doctest for Loss
Check list: